-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generated code migration from request to node-fetch/isomorphic-fetch #773
generated code migration from request to node-fetch/isomorphic-fetch #773
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @davidgamero! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davidgamero The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! Can you split this PR into two commits: 1) generated code changes. 2) any hand-edited changes. It's basically impossible to review the generated code because there are so many files, but I would like to review any hand-edited changes. Also you need to sign the CLA. Just do the EasyCLA one b/c there is migration happening to that today-ish. |
The only hand-edited change in this PR is the GEN_COMMIT hash, and I will be making a separate PR for the hand-edited changes after this one for converting the Sounds good I'll do the CLA |
@davidgamero: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@davidgamero I created a |
perfect. just retargeted the PR |
looks like the PR might need a rebase- I could just open a new one at this point |
migration of OpenAPIGenerator code to current typescript generator that no longer uses
request
in reference to #754
Note: this will leave the master branch in a development state as the migration doesn't cover the /src/*.ts files that still use request.
Merging this would allow the work of updating all the non-generated code to be parallelized on master.
Notable remaining migration work:
-watch.ts, log.ts, and metrics.ts all directly implement
request
without using the generated apiclient-config.ts needs to be refactored from the
applyToRequest()
method to the newapplySecurityAuthentication()
method now that the generated code uses aSecurityAuthentication
interface for creating aRequestContext
instead of directly passinghttps.Options